From 4b873e4f3755f00530bc2ff353c49a4e977a98a2 Mon Sep 17 00:00:00 2001 From: Angel Kou Date: Mon, 23 Mar 2026 15:31:48 -0700 Subject: [PATCH] Fix user-agent integration test for orchestration ID --- .github/workflows/integration.yml | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 06827f2..ebd04e1 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -154,22 +154,24 @@ jobs: return endpoint({}).headers['user-agent'] result-encoding: string - run: | + # User-agent format: [actions_orchestration_id/] octokit-core.js/ ... + # When ACTIONS_ORCHESTRATION_ID is set, the orchestration ID is inserted after the prefix echo "- Validating user-agent default" - expected="actions/github-script octokit-core.js/" - if [[ "${{steps.user-agent-default.outputs.result}}" != "$expected"* ]]; then - echo $'::error::\u274C' "Expected user-agent to start with '$expected', got ${{steps.user-agent-default.outputs.result}}" + ua="${{steps.user-agent-default.outputs.result}}" + if [[ "$ua" != "actions/github-script"* ]] || [[ "$ua" != *"octokit-core.js/"* ]]; then + echo $'::error::\u274C' "Expected user-agent to start with 'actions/github-script' and contain 'octokit-core.js/', got $ua" exit 1 fi echo "- Validating user-agent set to a value" - expected="foobar octokit-core.js/" - if [[ "${{steps.user-agent-set.outputs.result}}" != "$expected"* ]]; then - echo $'::error::\u274C' "Expected user-agent to start with '$expected', got ${{steps.user-agent-set.outputs.result}}" + ua="${{steps.user-agent-set.outputs.result}}" + if [[ "$ua" != "foobar"* ]] || [[ "$ua" != *"octokit-core.js/"* ]]; then + echo $'::error::\u274C' "Expected user-agent to start with 'foobar' and contain 'octokit-core.js/', got $ua" exit 1 fi echo "- Validating user-agent set to an empty string" - expected="actions/github-script octokit-core.js/" - if [[ "${{steps.user-agent-empty.outputs.result}}" != "$expected"* ]]; then - echo $'::error::\u274C' "Expected user-agent to start with '$expected', got ${{steps.user-agent-empty.outputs.result}}" + ua="${{steps.user-agent-empty.outputs.result}}" + if [[ "$ua" != "actions/github-script"* ]] || [[ "$ua" != *"octokit-core.js/"* ]]; then + echo $'::error::\u274C' "Expected user-agent to start with 'actions/github-script' and contain 'octokit-core.js/', got $ua" exit 1 fi echo $'\u2705 Test passed' | tee -a $GITHUB_STEP_SUMMARY