Merge pull request #79 from actions/add-settings-url-to-error

Add repo settings URL to help users react to error message
2026-03-28 08:54:53 +00:00 · 2022-11-21 09:51:21 -06:00 · 2022-11-17 12:40:28 -06:00 · 2022-11-16 20:12:48 -06:00 · 2022-11-17 02:08:59 +00:00 · 2022-11-16 20:07:55 -06:00
7 changed files with 21 additions and 15 deletions
--- a/.github/workflows/check-dist.yml
+++ b/.github/workflows/check-dist.yml
@@ -21,10 +21,10 @@ jobs:
    runs-on: ubuntu-latest

    steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3

      - name: Set Node.js 16.x
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
        with:
          node-version: 16.x

--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -10,10 +10,10 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      - name: Set Node.JS
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
        with:
          node-version: 16.x

--- a/dist/index.js
+++ b/dist/index.js
@@ -6909,7 +6909,8 @@ function getRequiredVars() {
    actionsId: process.env.GITHUB_ACTION,
    githubToken: core.getInput('token'),
    githubApiUrl: process.env.GITHUB_API_URL ?? 'https://api.github.com',
-    artifactName: core.getInput('artifact_name') ?? 'github-pages',
+    githubServerUrl: process.env.GITHUB_SERVER_URL ?? 'https://github.com',
+    artifactName: core.getInput('artifact_name') || 'github-pages',
    isPreview: core.getInput('preview') === 'true'
  }
 }
@@ -6957,6 +6958,7 @@ class Deployment {
    this.requestedDeployment = false
    this.deploymentInfo = null
    this.githubApiUrl = context.githubApiUrl
+    this.githubServerUrl = context.githubServerUrl
    this.artifactName = context.artifactName
    this.isPreview = context.isPreview === true
  }
@@ -7027,7 +7029,8 @@ class Deployment {
        } else if (error.response.status == 403) {
          errorMessage += `Ensure GITHUB_TOKEN has permission "pages: write".`
        } else if (error.response.status == 404) {
-          errorMessage += `Ensure GitHub Pages has been enabled.`
+          const pagesSettingsUrl = `${this.githubServerUrl}/${this.repositoryNwo}/settings/pages`
+          errorMessage += `Ensure GitHub Pages has been enabled: ${pagesSettingsUrl}`
        } else if (error.response.status >= 500) {
          errorMessage += `Server error, is githubstatus.com reporting a Pages outage? Please re-run the deployment at a later time.`
        }
--- a/dist/index.js.map
+++ b/dist/index.js.map
--- a/package-lock.json
+++ b/package-lock.json
@@ -4767,9 +4767,9 @@
      }
    },
    "node_modules/minimatch": {
-      "version": "3.0.4",
-      "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz",
-      "integrity": "sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==",
+      "version": "3.1.2",
+      "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.1.2.tgz",
+      "integrity": "sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==",
      "dev": true,
      "dependencies": {
        "brace-expansion": "^1.1.7"
@@ -9694,9 +9694,9 @@
      "dev": true
    },
    "minimatch": {
-      "version": "3.0.4",
-      "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz",
-      "integrity": "sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==",
+      "version": "3.1.2",
+      "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.1.2.tgz",
+      "integrity": "sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==",
      "dev": true,
      "requires": {
        "brace-expansion": "^1.1.7"
--- a/src/context.js
+++ b/src/context.js
@@ -12,7 +12,8 @@ function getRequiredVars() {
    actionsId: process.env.GITHUB_ACTION,
    githubToken: core.getInput('token'),
    githubApiUrl: process.env.GITHUB_API_URL ?? 'https://api.github.com',
-    artifactName: core.getInput('artifact_name') ?? 'github-pages',
+    githubServerUrl: process.env.GITHUB_SERVER_URL ?? 'https://github.com',
+    artifactName: core.getInput('artifact_name') || 'github-pages',
    isPreview: core.getInput('preview') === 'true'
  }
 }
--- a/src/deployment.js
+++ b/src/deployment.js
@@ -24,6 +24,7 @@ class Deployment {
    this.requestedDeployment = false
    this.deploymentInfo = null
    this.githubApiUrl = context.githubApiUrl
+    this.githubServerUrl = context.githubServerUrl
    this.artifactName = context.artifactName
    this.isPreview = context.isPreview === true
  }
@@ -94,7 +95,8 @@ class Deployment {
        } else if (error.response.status == 403) {
          errorMessage += `Ensure GITHUB_TOKEN has permission "pages: write".`
        } else if (error.response.status == 404) {
-          errorMessage += `Ensure GitHub Pages has been enabled.`
+          const pagesSettingsUrl = `${this.githubServerUrl}/${this.repositoryNwo}/settings/pages`
+          errorMessage += `Ensure GitHub Pages has been enabled: ${pagesSettingsUrl}`
        } else if (error.response.status >= 500) {
          errorMessage += `Server error, is githubstatus.com reporting a Pages outage? Please re-run the deployment at a later time.`
        }
Author	SHA1	Message	Date
James M. Greene	20a4baa109	Merge pull request #79 from actions/add-settings-url-to-error Add repo settings URL to help users react to error message	2022-11-21 09:51:21 -06:00
James M. Greene	3ffff52a9c	Add repo settings URL to help users react to error message	2022-11-17 12:40:28 -06:00
James M. Greene	af875e2038	Merge pull request #78 from actions/dependabot/npm_and_yarn/minimatch-3.1.2 Bump minimatch from 3.0.4 to 3.1.2	2022-11-16 20:12:48 -06:00
dependabot[bot]	2ca5e08d58	Bump minimatch from 3.0.4 to 3.1.2 Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	2022-11-17 02:08:59 +00:00
James M. Greene	9b6b97b3c8	Merge pull request #77 from actions/fix-artifact Fix artifact name defaulting behavior	2022-11-16 20:07:55 -06:00
James M. Greene	9b641caa4a	Fix artifact name defaulting behavior	2022-11-16 20:02:14 -06:00
Yoann Chaudet	a9645ed88d	Merge pull request #74 from actions/bump-actions Bump actions	2022-11-16 13:08:35 -08:00
Yoann Chaudet	fa8a0ed4a7	Merge branch 'main' into bump-actions	2022-11-16 13:05:29 -08:00
Yoann Chaudet	5bc2a71d98	Bump actions:	2022-10-31 16:32:36 -07:00