Fix superfluous HttpError: Not Found by throwing user-friendly errors

Instead of logging a detailed error with core.error() and then re-throwing
the raw HTTP error (which gets logged again by core.setFailed() in index.js),
throw a new Error with the user-friendly message directly. This eliminates
the duplicate/superfluous raw error output like "HttpError: Not Found".

Fixes #125

Agent-Logs-Url: https://github.com/actions/configure-pages/sessions/ee6b7f39-cfc5-415b-b70c-826c2b8cfcfe

Co-authored-by: yoannchaudet <14911070+yoannchaudet@users.noreply.github.com>

dist/index.js

@@ -36419,11 +36419,9 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
     pageObject = await getPagesSite({ githubToken })
   } catch (error) {
     if (!enablement) {
-      core.error(
+      throw new Error(
-        `Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action. Error: ${error.message}`,
+        `Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action.`
-        convertErrorToAnnotationProperties(error)
       )
-      throw error
     }
     core.warning(`Get Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
   }
@@ -36433,8 +36431,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
     try {
       pageObject = await enablePagesSite({ githubToken })
     } catch (error) {
-      core.error(`Create Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
+      throw new Error(`Create Pages site failed. Error: ${error.message}`)
-      throw error
     }
 
     // This somehow implies that the Pages site was already created but initially failed to be retrieved.
@@ -36443,8 +36440,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
       try {
         pageObject = await getPagesSite({ githubToken })
       } catch (error) {
-        core.error(`Get Pages site still failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
+        throw new Error(`Get Pages site still failed. Error: ${error.message}`)
-        throw error
       }
     }
   }

src/api-client.js

@@ -43,11 +43,9 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
     pageObject = await getPagesSite({ githubToken })
   } catch (error) {
     if (!enablement) {
-      core.error(
+      throw new Error(
-        `Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action. Error: ${error.message}`,
+        `Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action.`
-        convertErrorToAnnotationProperties(error)
       )
-      throw error
     }
     core.warning(`Get Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
   }
@@ -57,8 +55,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
     try {
       pageObject = await enablePagesSite({ githubToken })
     } catch (error) {
-      core.error(`Create Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
+      throw new Error(`Create Pages site failed. Error: ${error.message}`)
-      throw error
     }
 
     // This somehow implies that the Pages site was already created but initially failed to be retrieved.
@@ -67,8 +64,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
       try {
         pageObject = await getPagesSite({ githubToken })
       } catch (error) {
-        core.error(`Get Pages site still failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
+        throw new Error(`Get Pages site still failed. Error: ${error.message}`)
-        throw error
       }
     }
   }

src/api-client.test.js

@@ -169,8 +169,7 @@ describe('apiClient', () => {
         })
       } catch (error) {
         erred = true
-        // re-raised error
+        expect(error.message).toContain('Get Pages site failed')
-        expect(error.response.status).toEqual(404)
       }
       expect(erred).toBe(true)
       expect(mockGetPages).toHaveBeenCalledTimes(1)
@@ -188,8 +187,7 @@ describe('apiClient', () => {
         })
       } catch (error) {
         erred = true
-        // re-raised error
+        expect(error.message).toContain('Create Pages site failed')
-        expect(error.response.status).toEqual(500)
       }
       expect(erred).toBe(true)
       expect(mockGetPages).toHaveBeenCalledTimes(1)